Backport "HBASE-30101 Move login() before RpcServer construction (#8122)" to branch-2#8173
Open
junegunn wants to merge 1 commit intoapache:branch-2from
Open
Backport "HBASE-30101 Move login() before RpcServer construction (#8122)" to branch-2#8173junegunn wants to merge 1 commit intoapache:branch-2from
junegunn wants to merge 1 commit intoapache:branch-2from
Conversation
The RpcServer constructor calls userProvider.getCurrentUserName() (HBASE-28321) which triggers UserGroupInformation.getCurrentUser(). If the server has not logged in yet, UGI bootstraps from the ticket cache and spawns a TGT renewer for whichever principal happens to be there, regardless of the principal the server is configured to use. Resolve the hostname up front via DNS.getHostname(...) and run the ZK client and server logins before createRpcServices(), so that UGI is already bound to the keytab principal by the time the RpcServer constructor runs. HRegionServer.getUseThisHostnameInstead() previously fell back to rpcServices.getSocketAddress().getHostName() when the reverse-DNS disable flag was set; that branch now uses DNS.getHostname directly so it no longer depends on rpcServices being constructed. Signed-off-by: Duo Zhang <zhangduo@apache.org>
junegunn
added
the
backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of resolution:
HBaseServerBase.javadoesn't exist inbranch-2; the constructor logic lives directly inHRegionServer. Kept the file deleted withgit rm.HBaseServerBase) intoHRegionServer:createRpcServices().resolveHostName()helper usingDNS.getHostname(conf, getDNSServerType()).getDNSServerType()returningREGIONSERVER(HMaster'sMASTERoverride was already in the staged hunk).UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEYbranch ingetUseThisHostnameInsteadto useDNS.getHostnameinstead ofrpcServices.isa.getHostName().