Skip to content

HBASE-30142 Resolve NPE while running recoverUnknown command because null RegionLocation #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Umeshkumar9414 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

HBASE-30142 Resolve NPE while running recoverUnknown command because null RegionLocation #8192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,11 +980,14 @@ public synchronized boolean isServerDead(ServerName serverName) {
/**
* Check if a server is unknown. A server can be online, or known to be dead, or unknown to this
* manager (i.e, not online, not known to be dead either; it is simply not tracked by the master
* any more, for example, a very old previous instance).
* any more, for example, a very old previous instance). A null serverName should not be
* considered unknown. We set regionLocation null before finding the assign candidate (in-between
* region transition) or while marking it OFFLINE/FAILED_OPEN For more info regarding null-check
* in this refer HBASE-30142
*/
public boolean isServerUnknown(ServerName serverName) {
return serverName == null
|| (!onlineServers.containsKey(serverName) && !deadservers.isDeadServer(serverName));
return serverName != null
&& (!onlineServers.containsKey(serverName) && !deadservers.isDeadServer(serverName));
}

public void shutdownCluster() {
Expand Down