HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names… #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@apurtell @openinx @xcangCRM - this is the branch-1 backport of HBASE-23251, which you reviewed last week. |
|
💔 -1 overall
This message was automatically generated. |
gjacoby126
force-pushed
the
HBASE-23288
branch
from
bb3a110 to
144808c
Compare
Contributor
Author
|
Fixed checkstyle nits, will now take a look at the test failures. |
Contributor
Author
|
Both failing tests pass locally for me, and neither looks related to this particular change. |
|
💔 -1 overall
This message was automatically generated. |
liuml07
reviewed
Nov 14, 2019
| long size = ClassSize.align(ClassSize.OBJECT + | ||
| // Algorithm reference, encodingon, checksumtype, Encryption.Context reference | ||
| 5 * ClassSize.REFERENCE + | ||
| 7 * ClassSize.REFERENCE + |
Member
There was a problem hiding this comment.
Seems this is the only difference when cherry-picking? I'd rather using the same expression as HBASE-23251 if possible so future change would find comfortable eyeballs.
Contributor
Author
There was a problem hiding this comment.
@liuml07 - the change to heap size was required to get an existing test in TestHFileBlock to pass.
Member
There was a problem hiding this comment.
Thanks @gjacoby126 I guess my comment is more about format for easier review and future change.
5 * ClassSize.REFERENCE +
2 * Bytes.SIZEOF_INT +
// usesHBaseChecksum, includesMvcc, includesTags and compressTags
4 * Bytes.SIZEOF_BOOLEAN +
Bytes.SIZEOF_LONG);
is changed to
7 * ClassSize.REFERENCE +
2 * Bytes.SIZEOF_INT +
// usesHBaseChecksum, includesMvcc, includesTags and compressTags
4 * Bytes.SIZEOF_BOOLEAN +
2 * ClassSize.ARRAY +
Bytes.SIZEOF_LONG);
Instead, I think it's better to have the same expression as master branch.
// Algorithm, checksumType, encoding, Encryption.Context, hfileName reference,
5 * ClassSize.REFERENCE + 2 * Bytes.SIZEOF_INT +
// usesHBaseChecksum, includesMvcc, includesTags and compressTags
4 * Bytes.SIZEOF_BOOLEAN + Bytes.SIZEOF_LONG +
//byte[] headers for column family and table name
2 * ClassSize.ARRAY + 2 * ClassSize.REFERENCE);
… to HFileContext) to branch-1
gjacoby126
force-pushed
the
HBASE-23288
branch
from
144808c to
0956bb0
Compare
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to HFileContext) to branch-1