HBASE-30155 MobFileCleanerChore does not shut down its internal execu…#8254
Merged
Merged
Conversation
apache#8222) Signed-off-by: Duo Zhang <zhangduo@apache.org>
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
This PR addresses HBASE-30155 by ensuring MobFileCleanerChore properly tears down its internally managed ThreadPoolExecutor when the chore is shut down, preventing lingering executor threads after cleanup.
Changes:
- Override
ScheduledChore.cleanup()inMobFileCleanerChoreto shut down the internal executor. - Add a focused unit test validating that
shutdown()results in the executor being shut down.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java | Adds cleanup() override to shut down the internal ThreadPoolExecutor on chore shutdown. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java | Adds a unit test asserting MobFileCleanerChore.shutdown() shuts down the internal executor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#8222)