Skip to content

HBASE-30168 Remove webkit from Playwright e2e tests; it crashes on CI #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndimiduk merged 1 commit into from
May 19, 2026
+7 −10
Merged

HBASE-30168 Remove webkit from Playwright e2e tests; it crashes on CI #8257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dev-support/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ RUN curl -fsSL "https://nodejs.org/dist/$NODE_VERSION/node-$NODE_VERSION-linux-x
&& tar -xzf node.tar.gz -C /usr/local --strip-components=1 \
&& rm node.tar.gz

# Install Playwright dependencies. Needed for docs PDF export and docs UI e2e tests.
RUN npx -y playwright install --with-deps
# Install OS-level dependencies for Playwright browsers used in CI.
# Only chromium and firefox — webkit crashes on Ubuntu 22.04 due to
# libsoup2/libsoup3 conflict (HBASE-30168).
RUN npx -y playwright install-deps chromium firefox
Comment on lines +81 to +84
Copy link
Copy Markdown
Contributor

@PDavid PDavid May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for improving this comment. 👍


##
# download sundry dependencies
Expand Down
2 changes: 1 addition & 1 deletion dev-support/generate-website/generate-hbase-website.Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pipeline {
user=$(whoami)
docker build -t hbase-build-website -f "${WORKSPACE}/component/dev-support/docker/Dockerfile" .
docker run --rm -v "${WORKSPACE}":/home/${user} -v /etc/passwd:/etc/passwd:ro -v /etc/group:/etc/group:ro \
-u `id -u`:`id -g` -e JAVA_HOME="/usr/lib/jvm/java-17" -e GIT_AUTHOR_NAME="HBase" \
-u `id -u`:`id -g` -e CI=true -e JAVA_HOME="/usr/lib/jvm/java-17" -e GIT_AUTHOR_NAME="HBase" \
Copy link
Copy Markdown
Contributor

@PDavid PDavid May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

-e GIT_AUTHOR_EMAIL="dev@hbase.apache.org" -e GIT_COMMITTER_NAME="HBase" \
-e GIT_COMMITTER_EMAIL="dev@hbase.apache.org" --workdir=/home/${user} hbase-build-website \
"component/dev-support/generate-website/build-hbase-website.sh" \
Expand Down
4 changes: 2 additions & 2 deletions hbase-website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"export-pdf": "playwright test e2e-tests/export-pdf.spec.ts --project=chromium --workers=1",
"fumadocs-init": "fumadocs-mdx",
"copy-pdf-to-build": "cp -r public/books build/client",
"ci": "npm run extract-all && npm run fumadocs-init && npm run lint && npm run typecheck && npm run test:unit:run && npm run build && npx playwright install && npm run test:e2e && npm run copy-pdf-to-build",
"ci-skip-tests": "npm run extract-all && npm run fumadocs-init && npm run build && npx playwright install && npm run export-pdf && npm run copy-pdf-to-build"
"ci": "npm run extract-all && npm run fumadocs-init && npm run lint && npm run typecheck && npm run test:unit:run && npm run build && npx playwright install chromium firefox && npm run test:e2e && npm run copy-pdf-to-build",
"ci-skip-tests": "npm run extract-all && npm run fumadocs-init && npm run build && npx playwright install chromium && npm run export-pdf && npm run copy-pdf-to-build"
},
"dependencies": {
"@hookform/resolvers": "^3.10.0",
Expand Down
5 changes: 0 additions & 5 deletions hbase-website/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ export default defineConfig({
{
name: "firefox",
use: { ...devices["Desktop Firefox"] }
},

{
name: "webkit",
use: { ...devices["Desktop Safari"] }
}
],

Expand Down