Skip to content

HBASE-30145 Upgrade hbase-server to use junit5 Part17#8263

Open
liuxiaocs7 wants to merge 1 commit into
apache:branch-2.5from
liuxiaocs7:HBASE-30145-branch-2.5
Open

HBASE-30145 Upgrade hbase-server to use junit5 Part17#8263
liuxiaocs7 wants to merge 1 commit into
apache:branch-2.5from
liuxiaocs7:HBASE-30145-branch-2.5

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 requested a review from Copilot May 21, 2026 07:29
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label May 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the HBASE-30145 effort (Part 17 for branch-2.5) by migrating a large set of hbase-server RegionServer-related unit/integration tests from JUnit4 to JUnit5.

Changes:

  • Replaced JUnit4 assertions/annotations/rules (@Category, @BeforeClass, @Rule, @Test(expected=...), etc.) with JUnit5 equivalents (@Tag, @BeforeAll, TestInfo, assertThrows, etc.).
  • Removed HBaseClassTestRule and other JUnit4 rule-based infrastructure from migrated tests.
  • Migrated one parameterized test class to the JUnit5-style @HBaseParameterizedTestTemplate + @TestTemplate approach.

Reviewed changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSRpcServices.java JUnit5 assertions + @Tag migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java JUnit5 assertions + @Tag, @Disabled migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSChoresScheduled.java JUnit5 lifecycle (@BeforeAll/@AfterAll) + assertions migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRpcSchedulerFactory.java JUnit5 assertions + @BeforeEach migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRowTooBig.java Replaced JUnit4 expected-exception style with assertThrows.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRowPrefixBloomFilter.java JUnit5 assertions + lifecycle (@BeforeEach/@AfterEach) migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java JUnit5 assertions + TestInfo (replacing TestName) migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java JUnit5 assertions + TestInfo migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java JUnit5 lifecycle + assertions migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRemoveRegionMetrics.java JUnit5 lifecycle + TestInfo migration for per-test table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitRestriction.java JUnit5 lifecycle migration (@BeforeEach) and tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java JUnit5 lifecycle (@BeforeEach) + assertions message style update.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerScan.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java JUnit5 lifecycle + assertions message-parameter ordering migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerRejectDuringAbort.java JUnit5 lifecycle + assertions migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerRegionSpaceUseReport.java JUnit5 tags + assertion message-parameter ordering migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java JUnit5 tags + @Disabled migration; assertion message ordering updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerOnlineConfigChange.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java JUnit5 lifecycle + assertThrows conversion for exception expectations.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java JUnit5 lifecycle + TestInfo migration for per-test table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerHostname.java JUnit5 lifecycle + assertions migration (including fail).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerCrashDisableWAL.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerAccounting.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerAbortTimeout.java JUnit5 lifecycle + assertion message ordering migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerAbort.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaWaitForPrimaryFlushConf.java JUnit5 lifecycle + TestInfo migration for table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasWithRestartScenarios.java JUnit5 lifecycle + TestInfo migration for table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasWithModifyTable.java Migrated from JUnit4 Parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasAreDistributed.java JUnit5 lifecycle + tags + assertions migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java JUnit5 lifecycle + TestInfo migration; removed wildcard asserts.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java JUnit5 lifecycle + TestInfo migration for per-test table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java JUnit5 lifecycle + TestInfo migration; removed JUnit4 rules.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java JUnit5 lifecycle + TestInfo migration for per-test naming/logging.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java JUnit5 lifecycle + TestInfo migration for per-test table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionIncrement.java JUnit5 lifecycle + TestInfo migration; removed TestName rule.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionFavoredNodes.java JUnit5 assumptions (assumeTrue) and lifecycle migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEditsReplayAndAbort.java JUnit5 lifecycle + TestInfo migration; assertion conversions.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java JUnit5 lifecycle + TestInfo migration; assertion message ordering updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReadAndWriteRegionInfoFile.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java JUnit5 lifecycle + tags migration; assertion arg order update.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java JUnit5 tags + assertions migration (including assertNotNull).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java JUnit5 lifecycle + TestInfo migration; replaced failing-assert pattern with fail(...).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenSeqNumUnexpectedIncrease.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenRegionFailedMemoryLeak.java JUnit5 lifecycle + assertions migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestObservedExceptionsInBatch.java JUnit5 lifecycle + tags migration.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java JUnit5 tags + lifecycle migration; refactoring around test naming.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 force-pushed the HBASE-30145-branch-2.5 branch from fd30651 to 2405342 Compare May 21, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants