Skip to content

HBASE-30191 Upgrade hbase-testing-util to use junit5#8293

Merged
liuxiaocs7 merged 2 commits into
apache:masterfrom
liuxiaocs7:HBASE-30191
Jun 1, 2026
Merged

HBASE-30191 Upgrade hbase-testing-util to use junit5#8293
liuxiaocs7 merged 2 commits into
apache:masterfrom
liuxiaocs7:HBASE-30191

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates hbase-testing-util tests from JUnit 4 to JUnit 5 as part of HBASE-30191, aligning the module with existing HBase Jupiter test infrastructure.

Changes:

  • Replaces JUnit 4 annotations/imports with Jupiter equivalents.
  • Converts category-based classification to JUnit 5 @Tag constants.
  • Adds Jupiter test dependencies to hbase-testing-util.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hbase-testing-util/pom.xml Adds JUnit Jupiter API, engine, and params test dependencies.
TestHBaseTestingUtilitySpinup.java Migrates lifecycle, test, assertion, and category annotations to JUnit 5.
TestTestingHBaseCluster.java Migrates lifecycle, test, assertion, and tag annotations to JUnit 5.
TestTestingHBaseClusterImplForCPs.java Migrates class lifecycle, test, assertion, and tag annotations to JUnit 5.
TestingHBaseClusterReplicationTestBase.java Migrates inherited replication test lifecycle and assertions to JUnit 5.
TestTestingHBaseClusterReplicationTwoClusters.java Replaces JUnit 4 categories/class rule with Jupiter tags.
TestTestingHBaseClusterReplicationShareDfs.java Replaces JUnit 4 assertion/category/class rule usage with Jupiter equivalents.
TestTestingHBaseClusterReplicationShareZk.java Replaces JUnit 4 assertion/category/class rule usage with Jupiter equivalents.
TestTestingHBaseClusterReplicationShareZkDfs.java Replaces JUnit 4 assertion/category/class rule usage with Jupiter equivalents.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 035192f into apache:master Jun 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants