Skip to content

HBASE-23343 Thrift Resolve FQDN from SPNEGO principal#879

Closed
karthikhw wants to merge 1 commit intoapache:masterfrom
karthikhw:HBASE-23343
Closed

HBASE-23343 Thrift Resolve FQDN from SPNEGO principal#879
karthikhw wants to merge 1 commit intoapache:masterfrom
karthikhw:HBASE-23343

Conversation

@karthikhw
Copy link
Contributor

We need to manage different config groups in Ambari to run multiple thrift servers. This is because hbase thrift server will not able to resolve _HOST pattern from hbase.thrift.spnego.principal. so we explicitly specify the hostname for each group now.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch seems fine. Why have getServicePrincipalWithFQDN in SecurityUtil and not just in the class that needs it, in ThriftHttpServlet? It is only place that uses it?

Does not compile? Conflict?

@karthikhw
Copy link
Contributor Author

Thank you very much, @saintstack sir.
Sorry if am wrong. I simply thought to put all security-related stuff in one commonplace in HBase SecurityUtil.

I think we can close this pull request @saintstack. The same issue addressed via HBASE-23312 which is pushed on the same day.

@saintstack
Copy link
Contributor

Fixed by HBASE-23312 . Closing. Thanks @karthikhw

@saintstack saintstack closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants