Skip to content

Implement zk Meta client async crud#2354

Merged
xyuanlu merged 3 commits into
apache:metaclientfrom
xyuanlu:meta-client-beta2
Feb 22, 2023
Merged

Implement zk Meta client async crud#2354
xyuanlu merged 3 commits into
apache:metaclientfrom
xyuanlu:meta-client-beta2

Conversation

@xyuanlu

@xyuanlu xyuanlu commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2237

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR adds implementation to async CRUD operation in ZkMetaClient.
    Refactor test code - add a test base class for set up and tear down to be used in all ZkMetaClients test classes.

Tests

  • The following tests are written for this issue:
    TestZkMetaClientAsyncOperations.testAsyncCreateSetAndGet
    TestZkMetaClientAsyncOperations.testAsyncExistsAndDelete

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu force-pushed the meta-client-beta2 branch 2 times, most recently from 29f3fe5 to 42eab8f Compare January 30, 2023 23:13
@xyuanlu xyuanlu force-pushed the meta-client-beta2 branch 2 times, most recently from f61b82a to 730d5df Compare February 16, 2023 00:57
@xyuanlu xyuanlu force-pushed the meta-client-beta2 branch 3 times, most recently from 399d009 to 39c9848 Compare February 16, 2023 06:50
@xyuanlu xyuanlu changed the title [WIP] Implement zk Meta client async crud Implement zk Meta client async crud Feb 16, 2023
@xyuanlu xyuanlu marked this pull request as ready for review February 16, 2023 16:30

@rahulrane50 rahulrane50 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@qqu0127 qqu0127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address other comments

@xyuanlu xyuanlu merged commit 798ddbd into apache:metaclient Feb 22, 2023
Marcosrico pushed a commit to Marcosrico/helix that referenced this pull request Apr 19, 2023
Implement zk Meta client async crud
xyuanlu added a commit to xyuanlu/helix that referenced this pull request Apr 27, 2023
Implement zk Meta client async crud
xyuanlu added a commit that referenced this pull request May 20, 2023
Implement zk Meta client async crud
xyuanlu added a commit that referenced this pull request Jun 2, 2023
Implement zk Meta client async crud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants