Implement zk Meta client async crud#2354
Merged
Merged
Conversation
29f3fe5 to
42eab8f
Compare
f61b82a to
730d5df
Compare
399d009 to
39c9848
Compare
39c9848 to
a3e1ce8
Compare
rahulrane50
reviewed
Feb 17, 2023
qqu0127
reviewed
Feb 17, 2023
qqu0127
approved these changes
Feb 22, 2023
qqu0127
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please address other comments
Marcosrico
pushed a commit
to Marcosrico/helix
that referenced
this pull request
Apr 19, 2023
Implement zk Meta client async crud
xyuanlu
added a commit
to xyuanlu/helix
that referenced
this pull request
Apr 27, 2023
Implement zk Meta client async crud
xyuanlu
added a commit
that referenced
this pull request
May 20, 2023
Implement zk Meta client async crud
xyuanlu
added a commit
that referenced
this pull request
Jun 2, 2023
Implement zk Meta client async crud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#2237
Description
This PR adds implementation to async CRUD operation in ZkMetaClient.
Refactor test code - add a test base class for set up and tear down to be used in all ZkMetaClients test classes.
Tests
The following tests are written for this issue:
TestZkMetaClientAsyncOperations.testAsyncCreateSetAndGet
TestZkMetaClientAsyncOperations.testAsyncExistsAndDelete
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)