Skip to content

TTL Node Interface Methods#2388

Merged
xyuanlu merged 3 commits into
apache:metaclientfrom
Marcosrico:ttlnode
Mar 6, 2023
Merged

TTL Node Interface Methods#2388
xyuanlu merged 3 commits into
apache:metaclientfrom
Marcosrico:ttlnode

Conversation

@Marcosrico

@Marcosrico Marcosrico commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2237

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Interface methods for creating and renewing TTL methods. Added extra instance variables in MetaClient.Stat for future use cases. Please check design document for reasoning.

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Failed tests are from known issues. Below are the results from local testing:

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.186 s - in org.apache.helix.monitoring.mbeans.TestClusterAggregateMetrics
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 163.445 s - in org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@Marcosrico Marcosrico marked this pull request as ready for review March 2, 2023 22:47

@qqu0127 qqu0127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one nit on documentation

@mgao0 mgao0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xyuanlu xyuanlu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Please rerun failed test in CI.

@Marcosrico

Copy link
Copy Markdown
Contributor Author

This PR is ready to merge, approved by @mgao0 @qqu0127 @xyuanlu
Commit message: TTL Node Interface Methods

@xyuanlu xyuanlu merged commit b395e43 into apache:metaclient Mar 6, 2023
Marcosrico added a commit to Marcosrico/helix that referenced this pull request Apr 19, 2023
TTL Node Interface Methods
Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu pushed a commit to xyuanlu/helix that referenced this pull request Apr 27, 2023
TTL Node Interface Methods
Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu pushed a commit that referenced this pull request May 20, 2023
TTL Node Interface Methods
Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu pushed a commit that referenced this pull request Jun 2, 2023
TTL Node Interface Methods
Co-authored-by: mapeng <mapeng@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants