TTL Node Interface Methods#2388
Merged
Merged
Conversation
xyuanlu
reviewed
Mar 2, 2023
qqu0127
reviewed
Mar 3, 2023
qqu0127
approved these changes
Mar 3, 2023
qqu0127
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, one nit on documentation
xyuanlu
approved these changes
Mar 4, 2023
xyuanlu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the change. Please rerun failed test in CI.
Contributor
Author
Marcosrico
added a commit
to Marcosrico/helix
that referenced
this pull request
Apr 19, 2023
TTL Node Interface Methods Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu
pushed a commit
to xyuanlu/helix
that referenced
this pull request
Apr 27, 2023
TTL Node Interface Methods Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu
pushed a commit
that referenced
this pull request
May 20, 2023
TTL Node Interface Methods Co-authored-by: mapeng <mapeng@linkedin.com>
xyuanlu
pushed a commit
that referenced
this pull request
Jun 2, 2023
TTL Node Interface Methods Co-authored-by: mapeng <mapeng@linkedin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#2237
Description
Interface methods for creating and renewing TTL methods. Added extra instance variables in MetaClient.Stat for future use cases. Please check design document for reasoning.
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Failed tests are from known issues. Below are the results from local testing:
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)