[TEST PR] Fall back to current states when best possible calculation fails#3015
Closed
GrantPSpencer wants to merge 1 commit intoapache:masterfrom
Closed
[TEST PR] Fall back to current states when best possible calculation fails#3015GrantPSpencer wants to merge 1 commit intoapache:masterfrom
GrantPSpencer wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
When waged rebalance fails due to an exception that matches failure types to propagate, the controller errors out of the pipeline run and does not finish calculating a best possible state for that resource. This leads to an empty best possible state, when then leads to the partitions for that resource being dropped from nodes then immediately being reassigned once calculation proceeds. This is because the following code in MessageGenerationPhase drops the partitions: