Skip to content

[TEST PR] Fall back to current states when best possible calculation fails #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GrantPSpencer wants to merge 1 commit into from
+12 −0
Closed

[TEST PR] Fall back to current states when best possible calculation fails #3015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,18 @@ private BestPossibleStateOutput compute(ClusterEvent event, Map<String, Resource
.format("Failed to calculate best possible states for %d resources.",
failureResources.size()));

// Fall back to current states for resources that cannot be computed
failureResources.parallelStream().forEach(resourceName -> {
if (currentStateOutput.getCurrentStateMap(resourceName).isEmpty()) {
return;
}
IdealState fakeIS = new IdealState(resourceName);
currentStateOutput.getCurrentStateMap(resourceName).forEach((partition, stateMap) ->
fakeIS.setInstanceStateMap(partition.getPartitionName(), stateMap != null ? stateMap : new HashMap<>())
);
updateBestPossibleStateOutput(output, resourceMap.get(resourceName), fakeIS);
});

return output;
}

Expand Down