[fix] fix align cors configuration with header based authentication - #4267
Merged
Conversation
zqr10159
approved these changes
Aug 9, 2026
zqr10159
left a comment
zqr10159
left a comment
Member
There was a problem hiding this comment.
The CORS configuration now matches HertzBeat's header-based authentication model: cross-origin API access remains available, while ambient credentials are no longer permitted. The regression tests cover both halves of that contract, and the current-head checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Cross-origin access itself is unchanged: origins stay open and preflight requests are still answered, so no working request is affected.
Added a unit test that drives the real filter and asserts both halves — credentials are not allowed, and the preflight still succeeds.
Checklist
Add or update API