[fix] restore dropped rbac rule for single monitor deletion - #4269
Merged
Conversation
The deployment copy check accepted either shape anywhere in the file, so a rule carrying roles could sit under `excludedResource` and still pass. The two sections are not interchangeable: sureness consults the exclusion tree before it authenticates, and a three segment line there matches nothing, which leaves the endpoint unruled exactly like the mistyped separator this test already guards against. Parsing the copies as yaml and asserting per section closes that gap and also covers rules with no separator at all, which the line based scan skipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Aias00
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Corrected a typo in the separator in the "suresness" rule so that the character limit for deleting a single monitoring instance actually takes effect; added a test to verify that all rule formats are consistent with the deployment replica.
Checklist
Add or update API