HIVE-29756: maven shade plugin fixed to make beeline-standalone.jar#6626
Open
illiabarbashov-sketch wants to merge 7 commits into
Open
HIVE-29756: maven shade plugin fixed to make beeline-standalone.jar#6626illiabarbashov-sketch wants to merge 7 commits into
illiabarbashov-sketch wants to merge 7 commits into
Conversation
abstractdog
requested changes
Jul 22, 2026
abstractdog
left a comment
Contributor
There was a problem hiding this comment.
looks good mostly, only minor comments
| </manifestEntries> | ||
| </transformer> | ||
| <!-- | ||
| Without this, the java.sql.Driver service file ends up containing only one implementation of the |
Contributor
There was a problem hiding this comment.
for readers' convenience, "the java.sql.Driver service file" can become "META-INF/services/java.sql.Driver file"
Contributor
Author
There was a problem hiding this comment.
updated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
dnsjava is a Multi-Release JAR. Its DnsjavaInetAddressResolverProvider class lives at META-INF/versions/18/org/xbill/DNS/spi/DnsjavaInetAddressResolverProvider.class (Java 18+ only) which caused
Class not found exception for jdk18+ without multi-release
Otherwise only one implementation could be present in the final jar. (No hive driver exception fix)
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?