HIVE-29752: Docker publish workflow in forks should push to the fork's namespace#6627
Conversation
53f1710 to
be50e36
Compare
zabetak
left a comment
There was a problem hiding this comment.
Changes LGTM, will perform a test run of the action on my fork and if everything runs fine will submit the final approval.
|
Test action on fork repository is in progress: https://github.com/zabetak/hive/actions/runs/29935070044/job/88974409354 |
|
|
The intention sounds good, but it is not always the case that a GitHub user abc has a DockerHub repository abc. As of today, it is probably not an immediate problem, so it is okay to revisit it when someone hits the issue, though |
|
The test action in https://github.com/zabetak/hive/actions/runs/29935070044/job/88974409354 completed successfully and pushed the nightly images to the users (zabetak) namespace in https://hub.docker.com/r/zabetak/hive/tags. |



What changes were proposed in this pull request?
Derive the Docker Hub namespace from
github.repository_ownerinstead of the hardcoded apache defaultWhy are the changes needed?
The workflow defaulted the push namespace to
apacheregardless of which repository/fork it ran in.Does this PR introduce any user-facing change?
No
How was this patch tested?