Skip to content

HIVE-29752: Docker publish workflow in forks should push to the fork's namespace#6627

Merged
deniskuzZ merged 1 commit into
apache:masterfrom
deniskuzZ:HIVE-29752
Jul 23, 2026
Merged

HIVE-29752: Docker publish workflow in forks should push to the fork's namespace#6627
deniskuzZ merged 1 commit into
apache:masterfrom
deniskuzZ:HIVE-29752

Conversation

@deniskuzZ

@deniskuzZ deniskuzZ commented Jul 22, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Derive the Docker Hub namespace from github.repository_owner instead of the hardcoded apache default

Why are the changes needed?

The workflow defaulted the push namespace to apache regardless of which repository/fork it ran in.

Does this PR introduce any user-facing change?

No

How was this patch tested?

@deniskuzZ
deniskuzZ force-pushed the HIVE-29752 branch 3 times, most recently from 53f1710 to be50e36 Compare July 22, 2026 12:02
@deniskuzZ deniskuzZ changed the title HIVE-29752: Restrict Docker image publish workflow to the apache/hive repository HIVE-29752: Docker publish workflow in forks should push to the fork's namespace Jul 22, 2026
@deniskuzZ
deniskuzZ requested a review from okumin July 22, 2026 12:03

@zabetak zabetak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, will perform a test run of the action on my fork and if everything runs fine will submit the final approval.

@zabetak

zabetak commented Jul 22, 2026

Copy link
Copy Markdown
Member

Test action on fork repository is in progress: https://github.com/zabetak/hive/actions/runs/29935070044/job/88974409354

@sonarqubecloud

Copy link
Copy Markdown

@okumin

okumin commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The intention sounds good, but it is not always the case that a GitHub user abc has a DockerHub repository abc. As of today, it is probably not an immediate problem, so it is okay to revisit it when someone hits the issue, though

@zabetak

zabetak commented Jul 23, 2026

Copy link
Copy Markdown
Member

The test action in https://github.com/zabetak/hive/actions/runs/29935070044/job/88974409354 completed successfully and pushed the nightly images to the users (zabetak) namespace in https://hub.docker.com/r/zabetak/hive/tags.

@deniskuzZ
deniskuzZ merged commit ea78454 into apache:master Jul 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants