HIVE-29758: Fix maven warning for duplicate Iceberg dependency#6633
Open
ayushtkn wants to merge 1 commit into
Open
HIVE-29758: Fix maven warning for duplicate Iceberg dependency#6633ayushtkn wants to merge 1 commit into
ayushtkn wants to merge 1 commit into
Conversation
Contributor
|
LGTM +1 |
| <dependency> | ||
| <groupId>org.apache.hive</groupId> | ||
| <artifactId>hive-iceberg-handler</artifactId> | ||
| <scope>test</scope> |
Contributor
There was a problem hiding this comment.
nit: can we retain tag?
Member
Author
There was a problem hiding this comment.
hmm, I thought they added in compile scope because test wasn't enough, but the test is passing with test scope as well
[INFO] Running org.apache.hadoop.hive.cli.TestIcebergRESTCatalogGravitinoLlapLocalCliDriver
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 321.6 s -- in org.apache.hadoop.hive.cli.TestIcebergRESTCatalogGravitinoLlapLocalCliDriver
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Let me push to add the classifier and see if CI complains about anything
|
Aggarwal-Raghav
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix maven warning while building hive
Why are the changes needed?
that prints warning and confuses "me"
Does this PR introduce any user-facing change?
No
How was this patch tested?
Before
After