HIVE-29760: Improve SEARCH expansion to exploit NOT_BETWEEN operator#6634
Open
rubenada wants to merge 2 commits into
Open
HIVE-29760: Improve SEARCH expansion to exploit NOT_BETWEEN operator#6634rubenada wants to merge 2 commits into
rubenada wants to merge 2 commits into
Conversation
|
rubenada
commented
Jul 24, 2026
| INNER JOIN (SELECT `key`, `value` | ||
| FROM `default`.`src1` | ||
| WHERE (`key` < 20 OR `key` > 100) AND `key` IS NOT NULL) AS `t6` ON `t4`.`key` = `t6`.`key` | ||
| WHERE CAST(`key` AS DOUBLE) BETWEEN 20 AND 100 AND `key` IS NOT NULL) AS `t6` ON `t4`.`key` = `t6`.`key` |
Contributor
Author
There was a problem hiding this comment.
This unparse issue (operator unparses as "BETWEEN" instead of "NOT BETWEEN") will be handled in a separate follow-up ticket: https://issues.apache.org/jira/browse/HIVE-29765
On the plan itself the operator is correctly represented as a "NOT BETWEEN" though, so no issue there (see below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve SEARCH expansion to exploit NOT_BETWEEN operator
Why are the changes needed?
Generate a simpler expression in search expansion using NOT_BETWEEN, e.g.
x NOT BETWEEN 10, 20vs the currentx < 10 OR x > 20Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit tests added