HIVE-29779: Revive some test cases in HiveIcebergRESTViewCatalogTests - #6660
HIVE-29779: Revive some test cases in HiveIcebergRESTViewCatalogTests#6660okumin wants to merge 1 commit into
Conversation
| <property> | ||
| <name>metastore.iceberg.catalog.unique.table.location</name> | ||
| <value>true</value> | ||
| </property> |
There was a problem hiding this comment.
A common practice for RCK is to disable createTableInUniqueLocation since RSK's client can't share the flag with a catalog server.
However, as our REST catalog can enable the feature at the catalog level, we don't need to skip the test case.
https://github.com/apache/iceberg/blob/c53434560298176454501b28d12895becfb80e10/open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java#L112-L116
|
|
||
| @Override | ||
| public void completeCreateView() { | ||
| // This test case requires https://github.com/apache/iceberg/pull/14653 |
There was a problem hiding this comment.
We needed to disable completeCreateView, createAndReplaceViewWithLocation, createViewWithCustomMetadataLocation, and updateViewLocation since they hardcoded local file paths, though itests/test-docker uses S3A. Now, it is pluggable, and we can run all tests.
| @Disabled("https://github.com/apache/iceberg/pull/17420") | ||
| @Test | ||
| public void testLoadTableWithMissingMetadataFile(Path tempDir) throws IOException { | ||
| super.testLoadTableWithMissingMetadataFile(tempDir); |
There was a problem hiding this comment.
This test case assumes the warehouse location is a local filesystem. We can't run it here
okumin
changed the title
|
@okumin i think it duplicates HIVE-29764 |
okumin
changed the title
656abf8 to
0aa5672
Compare
|
@deniskuzZ @kokila-19 Thank you! Looks good to me. I updated the scope, and this PR has only view-related changes. I'd appreciate it if you could have a look. This is now nice to have, so take your time. |
|
3 participants
What changes were proposed in this pull request?
Re-enable four test cases related to view.
Why are the changes needed?
To avoid ad-hoc exclusions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
hive:testandhive:standalone-metastore-testimages based on the latest master branch./itests/test-docker/scripts/setup.shmvn --batch-mode test -Pitests -Pdocker -pl itests/test-docker