HIVE-29787: Separate default JSON metrics file locations for HS2 and HMS to prevent overwriting - #6666
Open
Aggarwal-Raghav wants to merge 1 commit into
Open
HIVE-29787: Separate default JSON metrics file locations for HS2 and HMS to prevent overwriting#6666Aggarwal-Raghav wants to merge 1 commit into
Aggarwal-Raghav wants to merge 1 commit into
Conversation
…HMS to prevent overwriting
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check HIVE-29787, The goal is to have separate json for hs2 and hms and additionally setting the default frequency for HS2 metrics to 60 sec i.e. same as of HMS
Why are the changes needed?
When both HiveServer2 and Hive Metastore are running on the same host with the
JsonFileMetricsReporterenabled, they experience a race condition resulting in telemetry/observability loss. Both processes default to writing their metric snapshots to the exact same file:/tmp/report.jsonDoes this PR introduce any user-facing change?
Yes . The
JsonFileMetricsReporterdumping file name default fallback location is changing from/tmp/report.json->/tmp/hs2-report.jsonor/tmp/hms-report.jsonaccordingly.How was this patch tested?
On Cluster testing