HIVE-29788: Support for rewrite_manifests iceberg procedure - #6667
Open
Aggarwal-Raghav wants to merge 1 commit into
Open
HIVE-29788: Support for rewrite_manifests iceberg procedure#6667Aggarwal-Raghav wants to merge 1 commit into
Aggarwal-Raghav wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for the Iceberg
REWRITE_MANIFESTSprocedure in Hive https://iceberg.apache.org/docs/latest/spark-procedures/#rewrite_manifestsThe implementation is very similar to Trino's approach https://github.com/trinodb/trino/blob/master/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/procedure/OptimizeManifests.java
Why are the changes needed?
Optimize manifest files using hive engine rather than running spark sql
CALL spark_catalog.system.rewrite_manifests(...). Also, hiveEXPIRE_SNAPSHOTSorOPTIMIZE TABLEdoesn't clean up manifest files.Does this PR introduce any user-facing change?
Yes. A new SQL command is now available for Hive-Iceberg users:
ALTER TABLE <table> EXECUTE REWRITE_MANIFESTSHow was this patch tested?
Using UT. Added
testRewriteManifestsandtestRewriteManifestsPartitionedinTestHiveIcebergSnapshotOperations