Skip to content

HIVE-29798: NumberFormatException while reading a table having UNION subdirs after ACID conversion #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abstractdog wants to merge 1 commit into
base: master
Choose a base branch
from
+455 −2
Open

HIVE-29798: NumberFormatException while reading a table having UNION subdirs after ACID conversion #6675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,8 @@ private VectorizedOrcAcidRowBatchReader(JobConf conf, OrcSplit orcSplit, Reporte
if (deleteEventRegistry.isEmpty() && !rowIdProjected) {
Path parent = orcSplit.getPath().getParent();
while (parent != null && !rootPath.equals(parent)) {
if (parent.getName().startsWith(AcidUtils.BASE_PREFIX)) {
String parentName = parent.getName();
if (parentName.startsWith(AcidUtils.BASE_PREFIX)) {
/**
* The assumption here is that any base_x is filtered out by
* {@link AcidUtils#getAcidState(Path, Configuration, ValidWriteIdList)}
Expand All @@ -351,7 +352,8 @@ private VectorizedOrcAcidRowBatchReader(JobConf conf, OrcSplit orcSplit, Reporte
*/
readerOptions.includeAcidColumns(false);
break;
} else {
} else if (parentName.startsWith(AcidUtils.DELTA_PREFIX)
|| parentName.startsWith(AcidUtils.DELETE_DELTA_PREFIX)) {
ParsedDeltaLight pd = ParsedDeltaLight.parse(parent);
if (validWriteIdList.isWriteIdRangeValid(pd.getMinWriteId(),
pd.getMaxWriteId()) == ValidWriteIdList.RangeResponse.ALL) {
Expand All @@ -361,6 +363,11 @@ private VectorizedOrcAcidRowBatchReader(JobConf conf, OrcSplit orcSplit, Reporte
break;
}
}
// Any other directory name (e.g. HIVE_UNION_SUBDIR_<N>/ produced by
// an INSERT ... UNION ALL against a table that was later converted
// to full ACID) is not an ACID container — skip it and keep walking
// up. Feeding such a name into ParsedDeltaLight.parse would throw
// NumberFormatException.
parent = parent.getParent();
}
}
Expand Down
Loading
Loading