HIVE-30017: Upgrade postgresql to 42.7.12 - #6751
Open
Akanksha-kedia wants to merge 2 commits into
Open
Conversation
Bumps org.postgresql:postgresql from 42.7.3 to 42.7.12 in both the root pom.xml and standalone-metastore/pom.xml, superseding apache#6599 (which targeted 42.7.11 and stalled without ASF JIRA credentials to merge).
Member
|
@Akanksha-kedia there are test failures which are related can u check |
TestBeelineArgParsing hardcoded the path to postgresql-42.7.3.jar in the local Maven repo to test loading it as a local driver jar. Bumping postgres.version to 42.7.12 meant that jar no longer exists at the build's local repo location, failing the test in CI (flagged by ayushtkn on Jenkins pr-head). Passes postgres.version through as a system property (same pattern already used for derby.version) and has the test build the jar path from it instead of a hardcoded version string.
Author
|
@ayushtkn Found it — TestBeelineArgParsing hardcoded the path to postgresql-42.7.3.jar in the local Maven repo. Bumping postgres.version means that jar no longer exists at that path, so the test failed to find it. Pushed a fix that derives the path from postgres.version instead (same pattern as derby.version). Verified locally with |
|
Author
|
@ayushtkn @uros-b @asf-ci-hive please help to review and merge |
Akanksha-kedia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bumps
org.postgresql:postgresqlfrom 42.7.3 to 42.7.12 inpom.xmlandstandalone-metastore/pom.xml.This supersedes #6599, which targeted 42.7.11 for the same CVE and stalled because the original author lacked ASF JIRA credentials to proceed. Picking it up here at a newer patch version per the discussion on that PR.
Why are the changes needed?
Addresses the CVE affecting
org.postgresql:postgresqlversions>= 42.2.0, < 42.7.11by moving to a later patched release.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Dependency version bump only; existing test suite covers usage.
cc @deniskuzZ @uros-b @pranitatiwari-per