HIVE-28216: Add commons-configuration2 2.15.0 dependency - #6754
Open
Akanksha-kedia wants to merge 1 commit into
Open
HIVE-28216: Add commons-configuration2 2.15.0 dependency#6754Akanksha-kedia wants to merge 1 commit into
Akanksha-kedia wants to merge 1 commit into
Conversation
Continues apache#5213, which stalled after review flagged that the config1 -> config2 import swap wasn't safe: the only in-repo consumers (AtlasRestClientBuilder, TestAtlasDumpTask) feed org.apache.atlas.ApplicationProperties.set(Configuration), and Atlas 2.4.0's API hardcodes commons-configuration 1.x's Configuration type, so those call sites can't move to config2 without an Atlas upgrade too. This adds commons-configuration2 as an available dependency for future use without touching the Atlas-coupled call sites, leaving the existing commons-configuration 1.x dependency and its two consumers untouched.
|
Author
|
The failing @ayushtkn @devaspatikrishnatri would appreciate a review when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds
org.apache.commons:commons-configuration2:2.15.0as a dependency inql/pom.xml(property declared in rootpom.xml), alongside the existingcommons-configuration:commons-configuration:1.10dependency, which is left untouched.This picks up the thread from #5213, which proposed migrating
commons-configuration1.x tocommons-configuration2but stalled after review.Why are the changes needed?
#5213 aimed to fix CVEs in commons-configuration 1.x by moving to config2. However, the only two consumers in this repo —
AtlasRestClientBuilder.javaandTestAtlasDumpTask.java— feedorg.apache.atlas.ApplicationProperties.set(Configuration), and Atlas 2.4.0's API (pinned inql/pom.xml) hardcodesorg.apache.commons.configuration.Configuration(config1). Swapping those call sites to config2'sConfigurationConverterdoes not compile against that Atlas API, and since Atlas itself depends on config1 internally, the vulnerable jar stays on the classpath transitively regardless of what Hive declares directly — a full fix needs an Atlas client upgrade as well, which is out of scope here.This PR only adds the config2 dependency so it's available, without touching the Atlas-coupled call sites, so as not to break the build while that larger Atlas upgrade is out of scope.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn install -DskipTests -pl ql -am— dependency resolves andqlcompiles cleanly with commons-configuration2 added alongside the existing commons-configuration 1.x dependency.cc @ayushtkn @devaspatikrishnatri