Load functions and proceduress asynchronously#4784
Closed
xdelox wants to merge 1 commit into
Closed
Conversation
xdelox
commented
Jan 15, 2025
| return sqlKeywords; | ||
| input.updateKeywords(sqlKeywords); | ||
| wSql.addLineStyleListener(sqlKeywords); | ||
| wSql.redraw(); |
Contributor
Author
There was a problem hiding this comment.
this line and the previous one look ignored if not executed in the main thread or the open() method
xdelox
commented
Jan 15, 2025
| sqlKeywords.add(functionsResultSet.getString("FUNCTION_NAME")); | ||
| String functionName = functionsResultSet.getString("FUNCTION_NAME"); | ||
| if (functionName.contains(";")) { | ||
| functionName = functionName.substring(0, functionName.indexOf(";")); |
Contributor
Author
There was a problem hiding this comment.
this string replacement is here because of MS SQL Server: in fact, the getFunctions() method returns functions with something more. Like, if the function name is helloworld(), it returns helloworld;1, so we have to remove the substring from the semicolon on
Contributor
|
I have made a new PR #4840 after the issues that have been raised, I no longer trust the results that we are getting from the JDBC drivers. To avoid issues we will use a fixed list per database. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.