issue #7393 : Merge Rows option to automatically line up input fields#7540
Merged
Conversation
…support Bring over the pieces missed when re-creating the PR after the main merge: align/align-off integration tests and golden data, mergerows docs, and TEST_FILTER support for the IT runner scripts (applied on top of current main without clobbering Spark client / CLIENT_UNZIP changes).
Force the classic per-workflow path when TEST_FILTER is set so filtered Docker integration tests actually run only matching main*.hwf files, and document the option for run-tests-docker.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
align_input_layoutswithdefaultBoolean = true), so reference and compare streams can use different field layouts for CDC-style diffs.align_input_layouts=N.run-tests-docker.sh/run-tests.shaccept optionalTEST_FILTERto run only matchingmain*.hwfworkflows (basename substring or shell glob, comma-separated). Speeds up Docker IT debugging, e.g.:Context
Addresses #7393. Ports the proven Merge Rows Plus layout-alignment approach from the neighbor hop-data-vault project into core Merge Rows.
Test plan
./mvnw -pl plugins/transforms/mergerows -am test(17 unit tests)sh hop run -j "IT transforms" -f main-0077-merge-rows.hwf -r local— all five unit tests pass (base, diff, passthrough, align, align-off)TEST_FILTER=0077-merge-rows