Keep the action name and plugin id when cloning, fixes #5644#7542
Merged
Conversation
Resource export clones every action before serializing it, so a copy constructor that drops the name or plugin id corrupts the export: * ActionCheckFilesLocked delegated to this(), which reset the name to an empty string. The exported workflow then held an empty <name>, and the server failed with a NullPointerException from WorkflowMeta.findAction() while resolving the hops. * ActionBase's copy constructor and ActionFtpPut used the two argument super(), which dropped the plugin id. The exported action was written without its <type>, and the server failed to load the workflow with "Unable to load workflow info from XML node". The ActionBase fix covers the eleven other actions that delegate to it. Adds unit tests guarding the name/plugin id on clone, and integration test 0010 which runs a workflow containing a Check Files Locked action on a remote server through the resource export. The test fails on both bugs before this change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource export clones every action before serializing it, so a copy constructor that drops the name or plugin id corrupts the export:
The ActionBase fix covers the eleven other actions that delegate to it.
Adds unit tests guarding the name/plugin id on clone, and integration test 0010 which runs a workflow containing a Check Files Locked action on a remote server through the resource export. The test fails on both bugs before this change.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.