Skip to content

Small changes to metadata categories #7590 #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcasters merged 1 commit into from
Jul 21, 2026
Merged

Small changes to metadata categories #7590 #7594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/src/main/java/org/apache/hop/ui/hopgui/perspective/metadata/MetadataCategories.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private record CategoryInfo(String id, String labelKey, String image) {}
new CategoryInfo(
HopMetadataCategory.CONNECTIONS,
"MetadataPerspective.Category.Connections",
"ui/images/database.svg"),
"ui/images/connection.svg"),
new CategoryInfo(
HopMetadataCategory.FILE_STORAGE,
"MetadataPerspective.Category.FileStorage",
Expand All @@ -74,11 +74,11 @@ private record CategoryInfo(String id, String labelKey, String image) {}
new CategoryInfo(
HopMetadataCategory.TESTING,
"MetadataPerspective.Category.Testing",
"ui/images/catalog.svg"),
"ui/images/test.svg"),
new CategoryInfo(
HopMetadataCategory.DATA_DEFINITION,
"MetadataPerspective.Category.DataDefinition",
"ui/images/partition_schema.svg"),
"ui/images/schema.svg"),
new CategoryInfo(
HopMetadataCategory.VARIABLES,
"MetadataPerspective.Category.Variables",
Expand Down
6 changes: 3 additions & 3 deletions ...esources/org/apache/hop/ui/hopgui/perspective/metadata/messages/messages_en_US.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ MetadataPerspective.ToolbarElement.HideEmpty.Tooltip=Hide empty types and catego
MetadataPerspective.Search.ResultCount={0} result(s)
MetadataPerspective.Category.Connections=Connections
MetadataPerspective.Category.FileStorage=File Storage
MetadataPerspective.Category.RunConfig=Run Configurations
MetadataPerspective.Category.Servers=Servers & Web Services
MetadataPerspective.Category.Execution=Execution & Monitoring
MetadataPerspective.Category.Servers=Servers and Web Services
MetadataPerspective.Category.Execution=Execution and Monitoring
MetadataPerspective.Category.Logging=Logging and Probes
MetadataPerspective.Category.Logging=Logging & Probes
MetadataPerspective.Category.Testing=Testing
MetadataPerspective.Category.DataDefinition=Data Definitions
Expand Down
3 changes: 3 additions & 0 deletions ui/src/main/resources/ui/images/connection.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions ui/src/main/resources/ui/images/test.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ui/src/test/java/org/apache/hop/ui/hopgui/perspective/metadata/MetadataCategoriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void orderOf_unknownComesAfterKnownButBeforeOther() {
@Test
void imageFor_knownReturnsConfiguredIconOthersFallBack() {
assertEquals(
"ui/images/database.svg", MetadataCategories.imageFor(HopMetadataCategory.CONNECTIONS));
"ui/images/connection.svg", MetadataCategories.imageFor(HopMetadataCategory.CONNECTIONS));
assertEquals(
"ui/images/location.svg", MetadataCategories.imageFor(HopMetadataCategory.FILE_STORAGE));
// Unknown and Other fall back to the generic metadata icon.
Expand Down
2 changes: 1 addition & 1 deletion ui/src/test/java/org/apache/hop/ui/hopgui/terminal/TerminalShellDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void testDetectDefaultShell() {
if (os.contains("win")) {
// Windows should return PowerShell or cmd
assertTrue(
shell.contains("powershell") || shell.contains("cmd"),
shell.toLowerCase().contains("powershell") || shell.contains("cmd"),
"Windows should detect PowerShell or cmd");
} else if (os.contains("mac") || os.contains("nix") || os.contains("nux")) {
// Unix-like systems should return a shell in /bin
Expand Down
Loading