issue #3137 : sample target hops and show data preview icons on hop arrows#7595
Merged
Conversation
… hop arrows Add IRowToListener so putRowTo destinations (Filter, Switch/Case, etc.) can be sampled separately by hop. Draw clickable data-grid icons on hops near the source transform for full pipeline transparency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements hop-level data sampling and preview icons for target hops (Filter Rows, Switch/Case, Java Filter, executors, etc.), addressing #3137.
Engine
IRowToListener/RowToAdapterwithrowWrittenTo(IRowMeta, Object[], IRowSet)so destination-aware listeners can keep mixed layouts apartBaseTransform.handlePutRowTo()notifies row-to listeners (still does not callIRowListener, which mixed layouts on target hops)ITransform,IEngineComponent,EngineComponentputRowToaligned toIRowToListenerinstead of incorrectly firingIRowListenerGUI sampling
PipelineRowSamplerHelperalso attaches hop samplers keyed by origin/destinationCanvas
AreaType.HOP_OUTPUT_DATA)Why
Target-stream transforms use
putRowTo(), which never called row listeners, so Filter/Switch/Case had no usable output preview. Sampling per hop (as discussed on the issue) makes data flow transparent on every target branch.How to test
Related
Fixes #3137