Skip to content

Fix Database Explorer tree expand hit target and side-button enablement on Windows - #7765

Merged
hansva merged 2 commits into
apache:mainfrom
leehaut:hotfix/lance-common-109
Aug 3, 2026
Merged

Fix Database Explorer tree expand hit target and side-button enablement on Windows#7765
hansva merged 2 commits into
apache:mainfrom
leehaut:hotfix/lance-common-109

Conversation

@leehaut

@leehaut leehaut commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

image
  • Fix unreliable expand/collapse of Catalogs/Tables/Views in DatabaseExplorerDialog on Windows (DPI/zoom misaligns the native > hit target; clicks often only worked in the tiny gap between > and the folder icon).

  • Make folder interactions usable: gutter/icon clicks toggle expand when the native handler does nothing, and double-click on folders expands/collapses.

  • Replace simple getters/setters with Lombok @Getter/@Setter; expand the Tables branch only after children are added.

…ent on Windows

Signed-off-by: lance <leehaut@gmail.com>
@leehaut
leehaut marked this pull request as ready for review August 3, 2026 13:30
…ent on Windows

Signed-off-by: lance <leehaut@gmail.com>
@hansva
hansva merged commit 27f00a0 into apache:main Aug 3, 2026
3 checks passed
@nadment

nadment commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The patch has unintended side effects on Windows: the arrows no longer work.

@leehaut

leehaut commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

The patch has unintended side effects on Windows: the arrows no longer work.

Thanks for reporting this. I'll reproduce the issue on Windows and work on a fix.

@leehaut

leehaut commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@nadment Thanks for the report. I re-tested this on Windows several times (including clicking the tree expand/collapse arrows > / ∨, not only keyboard navigation), and expand/collapse behaves normally for me.

Could you share a bit more detail so I can try to reproduce it on my side?

  • Hop version / build (or commit)
  • Windows display scaling (100% / 125% / 150% …)
  • Whether only the arrow is broken, or also folder-icon / double-click
  • Any short screen recording if possible

Happy to follow up once I can reproduce it.

@nadment

nadment commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I made a short video to show the problem that occurs when I single click on the arrows for expand.
databaseexplorer_7765.zip

Version : hop-client-2.19.0-20260805.123340-1
Windows display scaling 100%
Hop UI zoom level: 150%

@nadment

nadment commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

FYI, I'm also working on improving the database explorer.
#5376

@leehaut

leehaut commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@nadment Thanks for the video and the extra details — that helped a lot.

I've prepared an initial fix for the Windows display-scaling / arrow expand issue. (#7811)

Also great to hear you're working on improving the Database Explorer in #5376. Looking forward to your changes! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants