Skip to content

issue #7786: improve check results dialog colors and default filter #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansva merged 1 commit into from
Aug 5, 2026
+6 −7
Merged

issue #7786: improve check results dialog colors and default filter #7787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ui/src/main/java/org/apache/hop/ui/core/dialog/CheckResultDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ public class CheckResultDialog extends Dialog {
private Shell shell;
private final PropsUi props;

private Color red;
private Color yellow;

private boolean showSuccessfulResults = false;

private String transformName;
Expand All @@ -82,8 +79,9 @@ public String open() {
Shell parent = getParent();
Display display = parent.getDisplay();

red = display.getSystemColor(SWT.COLOR_RED);
yellow = display.getSystemColor(SWT.COLOR_YELLOW);
// Show successful results by default when there are no errors
showSuccessfulResults =
remarks.stream().noneMatch(cr -> cr.getType() == ICheckResult.TYPE_RESULT_ERROR);

shell = new Shell(parent, SWT.DIALOG_TRIM | SWT.RESIZE | SWT.MAX);
PropsUi.setLook(shell);
Expand Down Expand Up @@ -115,6 +113,7 @@ public String open() {

wNoOK = new Button(shell, SWT.CHECK);
wNoOK.setText(STRING_SHOW_SUCESSFUL);
wNoOK.setSelection(showSuccessfulResults);
PropsUi.setLook(wNoOK);
FormData fd = new FormData();
fd.left = new FormAttachment(0, 0);
Expand Down Expand Up @@ -220,10 +219,10 @@ public void getData() {
Color col = null;
switch (cr.getType()) {
case ICheckResult.TYPE_RESULT_ERROR:
col = red;
col = GuiResource.getInstance().getColorLightRed();
break;
case ICheckResult.TYPE_RESULT_WARNING:
col = yellow;
col = GuiResource.getInstance().getColorLight();
break;
default:
break;
Expand Down
Loading