Add Filter Rows condition isolation regression tests, fixes #7734 - #7855
Open
mattcasters wants to merge 1 commit into
Open
Add Filter Rows condition isolation regression tests, fixes #7734#7855mattcasters wants to merge 1 commit into
mattcasters wants to merge 1 commit into
Conversation
Lock in the runtime Condition clone behavior so GUI edits during an active Local Pipeline Engine run cannot change True/False routing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests that lock in Filter Rows runtime isolation of the filter
Conditionfrom shared transform metadata.Why
Issue #7734 reported that editing a Filter Rows condition in Hop GUI while a Local Pipeline Engine run was active could change True/False routing mid-execution.
That behavior was already fixed by #7686, which clones the condition into
data.conditionatinit()and evaluates that private copy instead ofmeta.getCondition(). The reporter's build (hop-client-2.19.0-20260724) predated that change.This PR does not change production code; it adds regression coverage so the isolation contract cannot regress:
init(), replacing or mutating the meta condition must not change runtime evaluation (atomic and nested cases).FilterRowsMeta.clone()deep-copies the condition tree /CValueinstances for copy-paste and undo safety.How
FilterRowsTest: simulate GUI meta mutation afterinit()and assertdata.conditionkeeps the original rule.FilterRowsMetaTest: assert deep clone independence for nested conditions.Testing
./mvnw -pl plugins/transforms/filterrows -am test -Dtest=FilterRowsTest,FilterRowsMetaTest -Dsurefire.failIfNoSpecifiedTests=falseAll 14 Filter Rows unit tests pass.
Fixes #7734