Harden explorer DnD against null drop targets, fixes #7933 - #7934
Merged
Conversation
Guard ExplorerPerspective drop/dragOver so a null RAP drop target or bad payload cannot NPE and kill the Hop Web session.
SessionResult treated channel-closed + available()==0 as EOF too early, which can drop late stdout packets on busy GitHub runners. Drain with a short post-close grace when empty, and run the embedded SSHD command handler asynchronously so onExit is not racy with the JSch client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExplorerPerspectivetree drop/drag-over handlers so a null RAP drop target (event.item == null) or invalid payload cannot NPE.DROP_NONE, only accept folder targets, null-safe parent checks, and wrap the drop path so unexpected errors show a dialog instead of killing the Hop Web session.Fixes #7933
Test plan