Issue #7940 : Add a configurator for Hop environment variables - #7942
Merged
Conversation
Add a bundled hop-misc-setup plugin with hop setup (CLI) and Tools → Configure Hop environment (GUI) so users can move HOP_CONFIG_FOLDER, HOP_AUDIT_FOLDER, HOP_JAVA_HOME, HOP_OPTIONS and HOP_SHARED_JDBC_FOLDERS out of the install tree. Launchers source a well-known hop-env script.
Add a Projects tab so a new HOP_CONFIG_FOLDER is not empty after restart: create a user-owned default project and register the install samples project in the new hop-config.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a bundled
hop-misc-setupplugin so new Hop users can move configuration out of the install tree.hop setup/hop setup show/hop setup applyHOP_CONFIG_FOLDER,HOP_AUDIT_FOLDER,HOP_JAVA_HOME,HOP_OPTIONS, andHOP_SHARED_JDBC_FOLDERSto:hop-env.sh/hop-env.cmd<install>/configwhen the new config folder is emptyRecommended folders:
~/.local/share/hop+~/.local/state/hop(Linux/macOS, honors XDG),%USERPROFILE%\.hop\config+audit(Windows). Existing defaults stay./configand./audit. Install fallbacks inConstare unchanged.Why
#7940
Without these variables Hop stores config and audit next to the install, which is lost on upgrade. The same friction showed up when documenting first-run setup (#7931).
How to test
./hop setup apply --defaults --dry-runHOP_CONFIG_FOLDERis used (About dialog / config path)~/.config/hop/hop-env.sh(or%USERPROFILE%\.hop\hop-env.cmd)Fixes #7940