issue #3025: unique metadata injection keys for Simple Mapping - #7956
Merged
Conversation
Add an opt-in injectionKeyPrefix on HopMetadataProperty so reused nested types get distinct MDI keys without changing XML/JSON serialization. Simple Mapping now prefixes input, output, and parameter mappings, with unit tests and MDI integration test 0061.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the duplicate Metadata Injection keys on Simple Mapping (issue #3025). Input and output mappings share
MappingIODefinition, so after theHopMetadataPropertymigration the dialog showed twoinput_transform/output_transformrows and assigning one overwrote the other.How
injectionKeyPrefixon@HopMetadataProperty. Serializationkey()/groupKey()are unchanged.BeanInjectionInfofor the dialog,HopMetadataInjectorfor runtime) apply the prefix to descendant keys and group keys.INPUT_,OUTPUT_, andPARAMETERS_prefixes so keys are unique.Compatibility
injectionKeyPrefixdefaults to empty).Tests
0061injects fromfiles/simple-mapping.xmland compares the generated pipeline to golden datasets.Fixes #3025