Issue #8059 : Rebrand hop-env files as Hop install spec and fix Open/Save As - #8103
Merged
Conversation
… Open/Save As Marketplace Open/Save As now uses HopVfs and variables so project-relative paths work. Rename the Environment tab to Install spec to distinguish these YAML files from project lifecycle environments. Add an Explorer file type and Edit YAML in Explorer for hand edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #8059.
The Marketplace Environment tab was easy to confuse with a project lifecycle environment, and Open / Save As failed when the path was a project-relative
'${PROJECT_HOME}'/…or VFS URI (Path.ofcannot resolve those).This change:
hop-env.yaml/full-client-env.yaml.How to test
hop-env.yamlunder the active project (path may be rewritten to'${PROJECT_HOME}'/hop-env.yaml). Re-open it; it should load.