Issue #7151 : Load Execute SQL script from a file and restyle the dialog - #8144
Merged
Conversation
…he dialog Allow a VFS SQL file as the script source instead of only embedding SQL in the pipeline XML. Put the Execute SQL script dialog on General, SQL, and Parameters tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Execute SQL script can load the script from a VFS SQL file instead of only storing it in the pipeline XML (#7151). The dialog is reorganized onto three tabs.
Changes
sql_from_file(same pattern as Table Input / Database Join): when set, SQL is read from that path at transform init; variables in the path are resolved; the editor is a read-only preview.GuiCompositeWidgetstabs:Get Fieldsremains on the button bar)getEffectiveSql, load/save ofsqlFromFile, and disabled GUI widgets0019-execute-sqlscript-sql-file(inline SQL is a dummySELECT 1; the file is the source of truth)Fixes #7151