Skip to content

Issue #7151 : Load Execute SQL script from a file and restyle the dialog - #8144

Merged
hansva merged 1 commit into
apache:mainfrom
mattcasters:issue-7151
Aug 28, 2026
Merged

Issue #7151 : Load Execute SQL script from a file and restyle the dialog#8144
hansva merged 1 commit into
apache:mainfrom
mattcasters:issue-7151

Conversation

@mattcasters

Copy link
Copy Markdown
Contributor

What

Execute SQL script can load the script from a VFS SQL file instead of only storing it in the pipeline XML (#7151). The dialog is reorganized onto three tabs.

Changes

  • Add sql_from_file (same pattern as Table Input / Database Join): when set, SQL is read from that path at transform init; variables in the path are resolved; the editor is a read-only preview.
  • Restyle the dialog with GuiCompositeWidgets tabs:
    • General: connection and insert/update/delete/read stats fields
    • SQL: filename, script editor, execute for each row, single statement, variable substitution, quote strings
    • Parameters: bind parameters and the argument table (Get Fields remains on the button bar)
  • Unit tests for getEffectiveSql, load/save of sqlFromFile, and disabled GUI widgets
  • Integration test 0019-execute-sqlscript-sql-file (inline SQL is a dummy SELECT 1; the file is the source of truth)
  • User-manual page updated with screenshots of the three tabs

Fixes #7151

…he dialog

Allow a VFS SQL file as the script source instead of only embedding SQL
in the pipeline XML. Put the Execute SQL script dialog on General, SQL,
and Parameters tabs.
@hansva
hansva merged commit 2130959 into apache:main Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Read SQL from file, not in transformation, execute SQL.

2 participants