Issue apache#2909 Document stream fields as wrapped Java objects in the JavaScript transform - #8166
Merged
Conversation
…sform Stream fields are added to the Rhino scope through Context.toObject(), so they reach the script as wrapped Java objects instead of JavaScript primitives. This makes a Boolean field always truthy and makes == / != between two fields compare object identity rather than values. Add a "Stream fields are Java objects" section to the JavaScript transform documentation describing the behaviour and the .valueOf() / parseInt() workarounds, including the null-safety check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream fields are added to the Rhino scope through Context.toObject(), so they reach the script as wrapped Java objects instead of JavaScript primitives. This makes a Boolean field always truthy and makes == / != between two fields compare object identity rather than values.
Add a "Stream fields are Java objects" section to the JavaScript transform documentation describing the behaviour and the .valueOf() / parseInt() workarounds, including the null-safety check.
Fixes #2909
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.