Fix project variable resolution in environment file paths - #8246
Merged
mattcasters merged 1 commit intoSep 3, 2026
Merged
Conversation
mattcasters
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8187.
Project variables were applied after environment configuration files were loaded, so paths such as ${CONFIG_HOME}/environment.json could not be resolved.
Apply project variables before resolving those paths, then reapply them afterward to preserve the existing variable precedence.
Added a regression test using CONFIG_HOME=${PROJECT_HOME}/config and a real environment configuration file. Before the fix, the expected environment value was null. With the fix, the file is loaded and all 13 ProjectTest tests pass.
Validation:
./mvnw -pl plugins/misc/projects -am -Dtest=ProjectTest -Dsurefire.failIfNoSpecifiedTests=false test
Spotless formatting and validation
git diff --check
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004