Skip to content

Issue #2664 : Harden pipeline unit tests (replacement notices, numeric compare, rename) - #8274

Open
mattcasters wants to merge 1 commit into
apache:mainfrom
mattcasters:issue-2664
Open

Issue #2664 : Harden pipeline unit tests (replacement notices, numeric compare, rename)#8274
mattcasters wants to merge 1 commit into
apache:mainfrom
mattcasters:issue-2664

Conversation

@mattcasters

Copy link
Copy Markdown
Contributor

When attaching an input or golden data set, Hop Gui now shows a notice (with Don't show this message again) that the transform is replaced with an Injector or Dummy during the test. That is typically done so the unit test does not read from or write to a file or database.

Number and BigNumber golden-data comparison now formats both values with a mask derived from field length and precision (for example length 7, precision 2 uses 00000.00;-0000.00), so values like sqrt(2) and 1.4142 match at the declared precision.

If a unit test is active and you rename a transform that has an input data set, golden data set, or tweak, the location is updated so the attachment stays on the renamed transform.

Documentation for pipeline unit tests, data sets, Dummy, and Injector is updated, including screenshots of the new notices.

Fixes #2664


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…numeric compare, rename)

When attaching an input or golden data set, inform the user that the
transform is replaced with an Injector or Dummy during the test.
Compare Number/BigNumber golden values with a length/precision format
mask, and keep data set locations in sync when a transform is renamed.

Fixes apache#2664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Pipeline unit tests: inform users about replacing transforms

1 participant