Issue #2664 : Harden pipeline unit tests (replacement notices, numeric compare, rename) - #8274
Open
mattcasters wants to merge 1 commit into
Open
Issue #2664 : Harden pipeline unit tests (replacement notices, numeric compare, rename)#8274mattcasters wants to merge 1 commit into
mattcasters wants to merge 1 commit into
Conversation
…numeric compare, rename) When attaching an input or golden data set, inform the user that the transform is replaced with an Injector or Dummy during the test. Compare Number/BigNumber golden values with a length/precision format mask, and keep data set locations in sync when a transform is renamed. Fixes apache#2664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attaching an input or golden data set, Hop Gui now shows a notice (with Don't show this message again) that the transform is replaced with an Injector or Dummy during the test. That is typically done so the unit test does not read from or write to a file or database.
Number and BigNumber golden-data comparison now formats both values with a mask derived from field length and precision (for example length 7, precision 2 uses
00000.00;-0000.00), so values likesqrt(2)and1.4142match at the declared precision.If a unit test is active and you rename a transform that has an input data set, golden data set, or tweak, the location is updated so the attachment stays on the renamed transform.
Documentation for pipeline unit tests, data sets, Dummy, and Injector is updated, including screenshots of the new notices.
Fixes #2664
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.