Code cleanup and optimization#355
Merged
Merged
Conversation
Contributor
jkmcl
commented
Jul 1, 2022
jkmcl
commented
- Make 2 public static fields final
- Remove 1 unused private static final field
- Replace Stack with LinkedList
added 3 commits
July 1, 2022 23:24
Replace Stack with LinkedList for better performance. Stack extends Vector which is synchronized and LinkedList is not.
michael-o
reviewed
Jul 1, 2022
ok2c
requested changes
Jul 1, 2022
| * The minimum (shortest-lived) deadline. | ||
| */ | ||
| public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE); | ||
| public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE); |
Member
There was a problem hiding this comment.
@jkmcl This breaks binary compatibility. See build failure in Travis C. URIBuilder optimization looks good, but two first commits look useless. Please drop them.
Contributor
Author
There was a problem hiding this comment.
@ok2c Sure, I've reverted those 2 commits. Please consider making Deadline.MIN_VALUE and Deadline.MAX_VALUE final in the future when the API is revised. Thanks
added 2 commits
July 2, 2022 01:18
michael-o
approved these changes
Jul 1, 2022
ok2c
approved these changes
Jul 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.