Hygiene changes to Deadline#392
Closed
jkmcl wants to merge 1 commit into
Closed
Conversation
Member
|
@jkmcl This cannot be done until 6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is the v5.3 branch which is in alpha stage, is it fine to break binary compatibility by making Deadline.MIN_VALUE and Deadline.MAX_VALUE final and removing the checked exception from Deadline.parse since it cannot be thrown from the method body?
For context regarding MIN_VALUE/MAX_VALUE: #355
Thanks.