Skip to content

Hygiene changes to Deadline #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkmcl wants to merge 1 commit into from
Closed

Hygiene changes to Deadline #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

package org.apache.hc.core5.util;

import java.text.ParseException;
import java.time.Instant;
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
Expand Down Expand Up @@ -60,12 +59,12 @@ public class Deadline {
/**
* The maximum (longest-lived) deadline.
*/
public static Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
public static final Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);

/**
* The minimum (shortest-lived) deadline.
*/
public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);

private static final DateTimeFormatter DATE_TIME_FORMATTER = new DateTimeFormatterBuilder()
.parseLenient()
Expand Down Expand Up @@ -122,9 +121,8 @@ public static Deadline fromUnixMilliseconds(final long value) {
*
* @param source a string in the format {@value #DATE_FORMAT}.
* @return a deadline from a string in the format {@value #DATE_FORMAT}.
* @throws ParseException if the specified source string cannot be parsed.
*/
public static Deadline parse(final String source) throws ParseException {
public static Deadline parse(final String source) {
if (source == null) {
return null;
}
Expand Down