RFC 9651: Structured Field Values for HTTP - #693
Open
arturobernalg wants to merge 1 commit into
Open
Conversation
ok2c
reviewed
Sep 4, 2026
| if (cursor.getUpperBound() > input.length()) { | ||
| throw new IllegalArgumentException("Parser cursor exceeds Structured Field input length"); | ||
| } | ||
| for (int i = cursor.getPos(); i < cursor.getUpperBound(); i++) { |
Member
There was a problem hiding this comment.
@arturobernalg We do permit non-ASCII characters in HTTP message header fields if the underlying connection has been configured with a custom CharCodingConfig. Can we be a bit more lenient here and also avoid this full header scan?
| private String parseDisplayString() throws ParseException { | ||
| require('%'); | ||
| require(Tokenizer.DQUOTE); | ||
| final ByteArrayOutputStream bytes = new ByteArrayOutputStream(); |
Member
There was a problem hiding this comment.
@arturobernalg Would you consider using ByteArrayBuffer here instead? It would be more efficient by not being synchronized and by avoiding an extra byte array copy,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Structured Field Values (RFC 9651) support under
org.apache.hc.core5.http.structured: a strict single-pass parser, a canonicalserializer, and an immutable value model covering Items, Lists, Dictionaries, parameters and inner lists, and all eight bare-item types (Integer, Decimal, String, Token, Byte Sequence, Boolean, Date, Display String).StructuredFieldHeadersintegrates it with message headers. Values are validated and normalized on construction, so serialization is total and round-trips are canonical.