try to fix failing test_008_restart - #733
Open
jfclere wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.6
Contributor
Author
|
I am not able to reproduce it. |
notroj
added a commit
to notroj/httpd
that referenced
this pull request
Sep 4, 2026
…tests. * test/pyhttpd/log.py (HttpdErrorLog.current_pos, .wait_for): New methods, to wait for a line logged after a noted position. * test/pyhttpd/env.py (HttpdTestEnv._apache_signal_restart): New method: run "httpd -k restart" or "-k graceful", which only signal the parent, then wait for the MPM to log "resuming normal operations" before checking is_live(). Until then the answer may come from the old generation, with the old config and about to be killed, which showed up as an empty reply in test_core_008_03_repeated under ASan. (apache_reload, apache_hard_restart): Use it. Fixes: 7172909 ("test/modules/core/test_008_restart.py: New test suite for server restart handling.") Fixes: 31d91bb ("test/pyhttpd/env.py (HttpdTestEnv.apache_hard_restart, read_pid_file): Moved here from the mod_systemd tests") Fixes: 4abdd20 ("test/modules/arch/linux/: New test suite.") GitHub: see also apache#733 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 4, 2026
* test/pyhttpd/log.py (HttpdErrorLog.current_pos, .wait_for): New methods, to wait for a line logged after a noted position. * test/pyhttpd/env.py (HttpdTestEnv._apache_signal_restart): New method: run "httpd -k restart" or "-k graceful", which only signal the parent, then wait for the MPM to log "resuming normal operations" before checking is_live(). Until then the answer may come from the old generation, with the old config and about to be killed, which showed up as an empty reply in test_core_008_03_repeated under ASan. (apache_reload, apache_hard_restart): Use it. Fixes: 7172909 ("test/modules/core/test_008_restart.py: New test suite for server restart handling.") GitHub: see also #733 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> GitHub: closes #737 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937877 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6