sql insert not honoring hoodie.merge.allow.duplicate.on.inserts properly.

[hudi-bot]

https://github.com/apache/hudi/pull/12610/files/5fbd4a15950f9d2b214ce3617164f68ac96fdc4b#r1925989101

JIRA info

• Link: https://issues.apache.org/jira/browse/HUDI-8904
• Type: Bug
• Fix version(s):
  • 1.1.0

[nsivabalan]

This appears to be fixed on master by PR #14052 (commit 4f80914b2030, fix: Allow INSERT INTO sql to preserve duplicates values by default). The two relevant changes:

1. ProvidesHoodieConfig.deduceSparkSqlInsertIntoWriteOperation no longer silently rewrites INSERT INTO to UPSERT when a preCombine/ordering field is present, so SQL INSERT INTO now actually runs as WriteOperation.INSERT as @nsivabalan called out in the PR review comment.
2. HoodieSparkSqlWriter.scala was changed from mergedParams.put(MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE, "true") to mergedParams.getOrElseUpdate(...), so a user-set hoodie.merge.allow.duplicate.on.inserts=false is no longer clobbered.

Coverage exists in TestInsertTable3.scala (Test enable hoodie.merge.allow.duplicate.on.inserts when write) which exercises both false (overwrite/dedup) and true (duplicates retained) flows. Closing as fixed in 1.1.0 — please reopen with a repro on a recent master build if you still see the original behavior.