test(client): improve native log and CDC write coverage - #19353
Merged
danny0405 merged 3 commits intoJul 28, 2026
Conversation
cshuo
changed the title
cshuo
marked this pull request as ready for review
July 23, 2026 03:35
danny0405
reviewed
Jul 24, 2026
danny0405
left a comment
danny0405
left a comment
Contributor
There was a problem hiding this comment.
I found two gaps where the new tests can pass without validating the behavior named in the test and PR.
cshuo
commented
Jul 24, 2026
danny0405
approved these changes
Jul 27, 2026
danny0405
enabled auto-merge (squash)
July 27, 2026 03:29
Member
|
@cshuo I think there are some failing CI tests, can you please help to fix them? Thank you! |
Addresses review comments 3642687180 and 3642687181.
auto-merge was automatically disabled
July 28, 2026 06:39
Head branch was pushed to by a user without write access
cshuo
force-pushed
the
codex/hudi-19352-native-log-cdc-coverage
branch
from
July 28, 2026 06:39
5d8636b to
d4fca99
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19353 +/- ##
============================================
+ Coverage 72.19% 72.25% +0.06%
- Complexity 32595 32628 +33
============================================
Files 2561 2561
Lines 148328 148328
Branches 18654 18654
============================================
+ Hits 107087 107177 +90
+ Misses 32774 32685 -89
+ Partials 8467 8466 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Closes #19352.
The native log format and CDC write handles in
hudi-client-commonlacked direct test coverage. This left record routing, file rollover, CDC supplemental logging modes, merge ordering, statistics publication, and representative failure handling insufficiently protected.This PR adds focused tests and raises every class in scope above the 70% line-coverage target.
HoodieNativeLogFormatWriterHoodieNativeLogAppendHandleFileGroupReaderBasedNativeLogAppendHandleHoodieNativeCDCLoggerHoodieNativeCDCFileWriterHoodieAvroNativeCDCLoggerHoodieSortedMergeHandleHoodieMergeHandleWithChangeLogSummary and Changelog
Commit 1: test(client): improve native log and CDC write coverage (
4956c8de4d3)Impact
Risk Level
Low. The change only adds and extends unit tests. The targeted suite, Checkstyle, and Apache RAT all pass.
Documentation Update
None.
Contributor's checklist
mvn -pl hudi-client/hudi-client-common -am -DskipTests -DskipITs -DskipSparkTests -DskipScalaTests checkstyle:check