Skip to content

fix(build): exclude nested .mvn directories from the RAT check - #19462

Merged
voonhous merged 1 commit into
apache:masterfrom
wombatu-kun:fix-19461-rat-nested-mvn
Aug 3, 2026
Merged

fix(build): exclude nested .mvn directories from the RAT check#19462
voonhous merged 1 commit into
apache:masterfrom
wombatu-kun:fix-19461-rat-nested-mvn

Conversation

@wombatu-kun

Copy link
Copy Markdown
Contributor

Describe the issue this Pull Request addresses

Closes #19461.

The RAT check inside the source release fails on hudi-trino/.mvn/modernizer/violations.xml and violations-production-code-only.xml. Both are tracked without an ASF header, and the root pom's <exclude>.mvn/**</exclude> does not cover them because a RAT exclude is relative to the project basedir, so it only matches <root>/.mvn/**. In the workspace .gitignore hides them, but create_source_directory.sh strips .gitignore from the tarball.

Summary and Changelog

  • Root pom.xml: widen the apache-rat exclude from .mvn/** to **/.mvn/**, and move it out from under the <!-- local files not in version control --> comment, which no longer describes it.

Verified on the tree the release job validates, built with create_source_directory.sh:

tree before after
source release directory Unapproved: 2, BUILD FAILURE Unapproved: 0, BUILD SUCCESS
workspace Unapproved: 0 Unapproved: 0

A headerless file planted at <root>/.mvn/ is excluded by **/.mvn/** exactly as by .mvn/**, so no coverage is lost.

Impact

Unblocks validate_staged_release.sh for the next release cut. No production code, API, config, or format change.

Risk Level

low - build configuration only, and the change only widens an existing exclude.

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable
  • CI passes on my PR

@wombatu-kun
wombatu-kun requested a review from voonhous August 3, 2026 03:44
@wombatu-kun

Copy link
Copy Markdown
Contributor Author

@voonhous Hi! please review this tiny fix when you have a sec

@hudi-agent hudi-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ 🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

Thanks for working on this! The PR widens the apache-rat exclude from .mvn/** to **/.mvn/** so nested .mvn directories (e.g. hudi-trino/.mvn/) are covered in the source-release tarball where .gitignore is stripped. No issues flagged from this automated pass — a Hudi committer or PMC member can take it from here for a final review.

cc @yihua

@voonhous
voonhous enabled auto-merge (squash) August 3, 2026 03:54
@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.81%. Comparing base (64afac0) to head (51b5a2a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19462      +/-   ##
============================================
- Coverage     76.81%   76.81%   -0.01%     
+ Complexity    33770    33767       -3     
============================================
  Files          2576     2576              
  Lines        143457   143457              
  Branches      17589    17589              
============================================
- Hits         110201   110193       -8     
- Misses        25010    25017       +7     
- Partials       8246     8247       +1     
Components Coverage Δ
hudi-common 82.26% <ø> (ø)
hudi-client 81.82% <ø> (-0.03%) ⬇️
hudi-flink 83.97% <ø> (+<0.01%) ⬆️
hudi-spark-datasource 74.22% <ø> (ø)
hudi-utilities 73.63% <ø> (-0.04%) ⬇️
hudi-cli 15.32% <ø> (ø)
hudi-hadoop 63.49% <ø> (ø)
hudi-sync 70.92% <ø> (+0.05%) ⬆️
hudi-io 79.60% <ø> (ø)
hudi-timeline-service 83.74% <ø> (-0.49%) ⬇️
hudi-cloud 64.00% <ø> (ø)
hudi-kafka-connect 53.96% <ø> (+0.76%) ⬆️
Flag Coverage Δ
common-and-other-modules 49.50% <ø> (+<0.01%) ⬆️
flink-integration-tests 48.80% <ø> (+<0.01%) ⬆️
hadoop-mr-java-client 43.41% <ø> (-0.01%) ⬇️
integration-tests 13.58% <ø> (-0.01%) ⬇️
spark-client-hadoop-common 48.68% <ø> (-0.01%) ⬇️
spark-java-tests 51.31% <ø> (-0.03%) ⬇️
spark-scala-tests 47.23% <ø> (+0.01%) ⬆️
utilities 36.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the size:XS PR with lines of changes in <= 10 label Aug 3, 2026
@hudi-bot

hudi-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@voonhous
voonhous merged commit 3160670 into apache:master Aug 3, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] build: source-release RAT validation fails on hudi-trino/.mvn/modernizer files

5 participants