fix(build): exclude nested .mvn directories from the RAT check - #19462
Conversation
|
@voonhous Hi! please review this tiny fix when you have a sec |
hudi-agent
left a comment
There was a problem hiding this comment.
Thanks for working on this! The PR widens the apache-rat exclude from .mvn/** to **/.mvn/** so nested .mvn directories (e.g. hudi-trino/.mvn/) are covered in the source-release tarball where .gitignore is stripped. No issues flagged from this automated pass — a Hudi committer or PMC member can take it from here for a final review.
cc @yihua
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19462 +/- ##
============================================
- Coverage 76.81% 76.81% -0.01%
+ Complexity 33770 33767 -3
============================================
Files 2576 2576
Lines 143457 143457
Branches 17589 17589
============================================
- Hits 110201 110193 -8
- Misses 25010 25017 +7
- Partials 8246 8247 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Describe the issue this Pull Request addresses
Closes #19461.
The RAT check inside the source release fails on
hudi-trino/.mvn/modernizer/violations.xmlandviolations-production-code-only.xml. Both are tracked without an ASF header, and the root pom's<exclude>.mvn/**</exclude>does not cover them because a RAT exclude is relative to the project basedir, so it only matches<root>/.mvn/**. In the workspace.gitignorehides them, butcreate_source_directory.shstrips.gitignorefrom the tarball.Summary and Changelog
pom.xml: widen the apache-rat exclude from.mvn/**to**/.mvn/**, and move it out from under the<!-- local files not in version control -->comment, which no longer describes it.Verified on the tree the release job validates, built with
create_source_directory.sh:Unapproved: 2, BUILD FAILUREUnapproved: 0, BUILD SUCCESSUnapproved: 0Unapproved: 0A headerless file planted at
<root>/.mvn/is excluded by**/.mvn/**exactly as by.mvn/**, so no coverage is lost.Impact
Unblocks
validate_staged_release.shfor the next release cut. No production code, API, config, or format change.Risk Level
low - build configuration only, and the change only widens an existing exclude.
Documentation Update
none
Contributor's checklist