fix(hubble): harden frontend validation and update license dependencies by imbajin · Pull Request #741 · apache/hugegraph-toolchain

imbajin · 2026-07-12T09:01:35Z

This PR contains the following changes:

Adds string type guard, Chinese character range support, and proper i18n messages to favorite names validation.
Addresses CodeQL and frontend PR review comments.
Updates the known dependencies list with kotlin-stdlib-common.

Please review and merge, thanks.

Copilot

Pull request overview

This PR strengthens Hubble frontend UX and validation by aligning “favorite name” rules with backend-compatible constraints (including i18n messaging), improving navigation feedback when operations are disabled, and updating the distro’s known-dependencies list.

Changes:

Added favorite-name validation helpers/rules (type guard + regex) with en/zh i18n messages, and updated tests accordingly.
Enhanced navigation item rendering to surface aggregated disable reasons, with a ConsoleItem test to cover the “Dashboard unavailable” scenario.
Updated dependency allowlist to include kotlin-stdlib-common-1.6.20.jar.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
hugegraph-hubble/hubble-fe/src/utils/rules.js	Adds `isValidFavoriteName` + `isFavoriteName`; switches account-name validation to reject `Error` objects.
hugegraph-hubble/hubble-fe/src/utils/rules.test.js	Extends i18n rule tests with favorite-name coverage.
hugegraph-hubble/hubble-fe/src/modules/analysis/QueryBar/ContentCommon/index.js	Disables/enables favorite submission based on backend-compatible favorite names and shows input error status.
hugegraph-hubble/hubble-fe/src/modules/analysis/QueryBar/ContentCommon/index.test.js	New test ensuring favorite submission remains disabled until the name is valid.
hugegraph-hubble/hubble-fe/src/modules/navigation/Item/index.js	Displays aggregated disabled reasons below the item list for better UX.
hugegraph-hubble/hubble-fe/src/modules/navigation/Item/index.module.scss	Adds styling for the disabled-reason text block.
hugegraph-hubble/hubble-fe/src/modules/navigation/ConsoleItem/index.test.js	Adds coverage for showing the “Dashboard unavailable” reason.
hugegraph-hubble/hubble-fe/src/i18n/resources/en-US/components/common.json	Adds `favorite_name_rule` translation.
hugegraph-hubble/hubble-fe/src/i18n/resources/zh-CN/components/common.json	Adds `favorite_name_rule` translation.
hugegraph-dist/scripts/dependency/known-dependencies.txt	Adds `kotlin-stdlib-common-1.6.20.jar` to known dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

VGalaxies

🚨 Review summary

Important

The release license inventory is incomplete, favorite-name validation remains inconsistent across entry points, and the new disabled-state explanation can overflow its navigation container.

🧪 How this was verified

Independent check	What it traced	Outcome
🧾 License inventory	Followed `check_dependencies.sh`, `known-dependencies.txt`, `hugegraph-dist/pom.xml`, and the `release-docs/LICENSE` copied into the archive.	Confirmed that the checker accepts `kotlin-stdlib-common-1.6.20.jar` while the packaged LICENSE still declares only `1.5.31`.
✍️ Favorite-name contract	Exercised invalid names against `ContentCommon`, traced `isValidFavoriteName`/`isFavoriteName`, and compared the analysis and algorithm create/rename flows that call the same collection API.	Retained two findings: four sibling flows still submit backend-invalid names, and the query-bar flow blocks input without displaying the new localized rule.
🧭 Navigation layout	Enumerated `Item` callers and compared the appended 160px reason with the 230px fixed parent and existing button/header dimensions.	Retained the overflow/layout finding; the separate contrast suggestion was dropped as lower-signal after lead verification.

Note

Targeted frontend tests could not run in the review checkout because react-scripts was not installed. The retained findings were therefore verified through exact call-site, packaging, and layout traces rather than claimed as test-proven.

_{🤖 Codex review · GPT-5.6 Sol · effort: xhigh}

Pengzna

Reviewed head 8a4e8d6. I independently confirmed the unresolved inline findings already present, so I am not posting duplicate comments. I found no additional issues beyond those threads.

- align favorite-name validation across all editors - show localized validation guidance for invalid names - allow navigation rows to grow for disabled reasons - add Kotlin dependency to the packaged license - cover all favorite creation and rename flows

VGalaxies

🚨 Review summary

Important

The validation and license changes align with their contracts, but the disabled-state explanation does not provide accessible text contrast.

📊 Risk dashboard

Signal	Result
🚦 Review gate	Blocked
🔎 Actionable findings	1 (1 P2)
🧪 Verification coverage	4 checks
⚠️ Confirmed / limited checks	1 / 0

🔬 Coverage details

⚠️

Navigation accessibility — Confirmed

Trace: Item, ConsoleItem, Home, navigation sizing and disabled-state styles

Conclusion: The reviewer retained the contrast defect after measuring the changed reason text and dropped the separate layout-shift concern as non-actionable.

✅ Favorite-name validation contract — Clear

Trace: FavoriteNameInput, isValidFavoriteName, QueryBar, all log create and rename flows, Constant.COMMON_NAME_PATTERN

Conclusion: The reviewer confirmed that the frontend type, character-set, and 48-character boundary checks match the backend naming contract, so no validation finding survived.

✅ Dependency and license inventory — Clear

Trace: dependency generation scripts, known-dependencies allowlist, packaged LICENSE

Conclusion: The reviewer confirmed that both generated inventories contain kotlin-stdlib-common 1.6.20 and found no release or compliance regression.

✅ Current-head consistency checks — Clear

Trace: scripts/check-i18n.js, git diff --check, current GitHub status checks

Conclusion: The i18n check reported 1,639 keys per locale, git diff validation was clean, and every current GitHub check completed successfully.

Warning

Verification limits

Targeted Jest tests could not run because react-scripts is not installed in the checkout.

_{🤖 Codex review · GPT-5.6 Sol · effort: xhigh}

VGalaxies · 2026-07-12T14:29:56Z

+
+.reason {
+    width: 160px;
+    color: #8c8c8c;


⚠️ P2 · Increase the disabled-reason text contrast

📐 Measured result

Metric Observed Required / target

Text contrast 3.36:1 >= 4.5:1

The changed 12px reason text uses #8c8c8c over the white navigation background, producing a 3.36:1 contrast ratio.

References: WCAG 2.2 contrast minimum

Warning
Impact: Low-vision users may be unable to read the persistent explanation of why Dashboard operations are disabled.

🛠️ Suggested change

Use a darker text color that reaches at least 4.5:1, such as #595959, which provides approximately 7.00:1 contrast.

_{🤖 Codex review · GPT-5.6 Sol · effort: xhigh}

imbajin added 3 commits July 12, 2026 14:44

fix(hubble): harden frontend validation

f35ea2a

fix(license): update known dependencies for kotlin-stdlib-common

51ab8b3

fix(hubble): address review comments on frontend validation

8a4e8d6

Copilot AI review requested due to automatic review settings July 12, 2026 09:01

dosubot Bot added dependencies Pull requests that update a dependency file hubble-fe labels Jul 12, 2026

github-actions Bot added the hubble hugegraph-hubble label Jul 12, 2026

dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 12, 2026

Copilot started reviewing on behalf of imbajin July 12, 2026 09:02 View session

Copilot AI reviewed Jul 12, 2026

View reviewed changes

Comment thread hugegraph-hubble/hubble-fe/src/utils/rules.test.js

VGalaxies reviewed Jul 12, 2026

View reviewed changes

Pengzna reviewed Jul 12, 2026

View reviewed changes

Pengzna mentioned this pull request Jul 12, 2026

perf(docker): avoid emulated Java builds #740

Merged

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 12, 2026

imbajin requested review from Pengzna and VGalaxies July 12, 2026 13:49

VGalaxies reviewed Jul 12, 2026

View reviewed changes

zyxxoo approved these changes Jul 12, 2026

View reviewed changes

zyxxoo merged commit f9c7192 into master Jul 12, 2026
14 checks passed

zyxxoo deleted the hubble-dev branch July 12, 2026 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(hubble): harden frontend validation and update license dependencies#741

fix(hubble): harden frontend validation and update license dependencies#741
zyxxoo merged 4 commits into
masterfrom
hubble-dev

imbajin commented Jul 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

VGalaxies left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pengzna left a comment

Uh oh!

VGalaxies left a comment •

edited

Loading

Uh oh!

VGalaxies Jul 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

imbajin commented Jul 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

VGalaxies left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

🚨 Review summary

🧪 How this was verified

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pengzna left a comment

Choose a reason for hiding this comment

Uh oh!

VGalaxies left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

🚨 Review summary

📊 Risk dashboard

🔬 Coverage details

Uh oh!

VGalaxies Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ P2 · Increase the disabled-reason text contrast

📐 Measured result

🛠️ Suggested change

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VGalaxies left a comment •

edited

Loading

VGalaxies left a comment •

edited

Loading

VGalaxies Jul 12, 2026 •

edited

Loading