fix: compare transform function parameters#840
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes TransformFunction equality for parameterized transforms so that bucket[N] and truncate[W] comparisons account for their parameters (and source types), and adds tests to prevent regressions.
Changes:
- Make
TransformFunction::Equalsavailable to derived classes (protected) for shared equality checks. - Override
EqualsinBucketTransformandTruncateTransformto includenum_buckets_/width_in equality. - Extend transform tests to cover parameter and source-type differences.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/iceberg/transform.h | Exposes base equality helper (Equals) to derived transforms. |
| src/iceberg/transform_function.h | Declares equality overrides for bucket/truncate transforms. |
| src/iceberg/transform_function.cc | Implements parameter-aware equality for bucket/truncate transforms. |
| src/iceberg/test/transform_test.cc | Adds equality tests for parameter and source-type differences. |
zhjwpku
approved these changes
Jul 23, 2026
| /// \brief Compare two partition specs for equality. | ||
| protected: | ||
| /// \brief Compare the common properties of two transform functions for equality. | ||
| [[nodiscard]] virtual bool Equals(const TransformFunction& other) const; |
Collaborator
There was a problem hiding this comment.
Nit: This is only used by the == overload, so maybe we can remove the [[nodiscard]] attribute? Same for the below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing